Fix InstalledPackageResolver cwd fallback lost by promoted property - #8237
Merged
Merged
Conversation
…erty The constructor reassigned the local $projectDirectory variable, but the promoted readonly property kept the original null. Any instance created without an explicit directory - e.g. the autowired one used by ComposerPackageConstraintFilter - then resolved the vendor dir as '/vendor' and always threw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstalledPackageResolverreassigns the local$projectDirectoryvariable in the constructor, but the value is bound to a promoted readonly property. The reassignment never reaches$this->projectDirectory, which staysnull:resolveVendorDir()then buildsnull . '/vendor'=/vendor, soresolve()always throws:This is invisible for
SetManager, becauseRectorConfigBuilderpassesgetcwd()explicitly. It is hit by the autowired instance behind the freshly addedComposerPackageConstraintFilter— any rule implementingComposerPackageConstraintInterface(#7877) currently crashes.Covered by a new test case that constructs the resolver without arguments.