Repository navigation
[PHPUnit60] Skip tests in classes with asserting parent lifecycle methods in AddDoesNotPerformAssertionToNonAssertingTestRector - #834
Merged
Conversation
TomasVotruba
force-pushed
the
does-not-perform-assertion-parent-lifecycle
branch
2 times, most recently
from
November 14, 2026 21:05
065f66a to
9b0678e
Compare
…hods in AddDoesNotPerformAssertionToNonAssertingTestRector
…on parent lifecycle methods
TomasVotruba
force-pushed
the
does-not-perform-assertion-parent-lifecycle
branch
from
November 14, 2026 23:48
759132c to
c87a7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #827, follow-up to #831.
PHPUnit counts assertions in parent lifecycle methods (
setUp(),tearDown(),#[Before], ...) toward every test. A test extending a base class that asserts insetUp()performs assertions, so it must not get#[DoesNotPerformAssertions].LifecycleMethodAssertAnalyzerwalks parent classes up to PHPUnit/SymfonyTestCase, max 5 parentsparent::<hook>()hides the parent oneBench
New
does_not_perform_assertion_parent_lifecycle_bench.php- 300 test classes on 10 chains of 4 parents, every other chain asserts in its topsetUp().maindoes_not_perform_assertion_lifecycle_bench.phpdoes_not_perform_assertion_parent_lifecycle_bench.php