[Sets] Remove deprecated PHPUnitSetProvider - #759
Merged
Conversation
The SetProviderInterface/Set machinery is deprecated in rectorphp/rector-src#8296, and since #757 and #758 this provider returned plain Set objects only, which SetManager::matchBySetGroups() never matched. Sets remain available via PHPUnitSetList constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetProviderInterface,Setand the whole set-object machinery are deprecated in rectorphp/rector-src#8296 — rules now carry their own version info viaComposerPackageConstraintInterface.Here the provider was already dead weight. Since #757 and #758 it returned plain
Setobjects only, andSetManager::matchBySetGroups()matchesComposerTriggeredSetexclusively:So
->withSetGroups(SetGroup::PHPUNIT)loaded nothing from it. It is also absent from core'sSetProviderCollectorlist (PHP, Core, Doctrine, Twig).Sets stay reachable as before:
No other reference to the class existed in configs, docs or tests.