[SetList] Add COMPOSER_BASED constant, remove empty DOCTRINE_BUNDLE_210 set - #499
Merged
Merged
Conversation
…10 set The composer-based set had no DoctrineSetList constant, so it could only be referenced by a raw path. Add COMPOSER_BASED for withSets() use. The doctrine-bundle-210 set has been an empty "only for BC" closure since #382 (2025-05), when the AsListener attribute moved to the doctrine-bundle 2.8 set. Remove the file and its deprecated constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small
DoctrineSetListcleanups.Add
COMPOSER_BASEDconfig/sets/composer-based.phphad no constant, so it could only be referenced by a raw path:Now:
->withComposerBased(doctrine: true)stays the recommended way - this is for configs that enumerate sets explicitly.Remove
DOCTRINE_BUNDLE_210config/sets/doctrine-bundle-210.phphas been an empty closure since #382 (2025-05), when theAsListenerattribute rule moved to the doctrine-bundle 2.8 set:It is not registered in
DoctrineSetProvider, so it never shows up in the prepared set list - the only way to reach it was the deprecatedDoctrineSetList::DOCTRINE_BUNDLE_210constant, which loaded a set that did nothing. File and constant removed together, same as 5f471cf.