[depre] Deprecate DoctrineSetList::YAML_TO_ANNOTATIONS set - #493
Merged
Conversation
The only rule this set configured, YamlToAttributeDoctrineMappingRector, was deprecated in #492. The set config is empty now, so using it is a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #492. That PR deprecated
YamlToAttributeDoctrineMappingRector- the only rule this set configured - so the set config is empty now and using it is a no-op.Marks the set constant deprecated, using the same native attribute the other deprecated sets in this class use:
#[Deprecated( message: 'The YamlToAttributeDoctrineMappingRector rule this set configured was deprecated, as incomplete and prone to create buggy code. Use custom rules tailored to your YAML mapping instead' )] public const string YAML_TO_ANNOTATIONS = __DIR__ . '/../../config/yaml-to-annotations.php';The constant and its config file stay in place, so existing configs referencing the set keep loading - they just get a deprecation notice.