Skip string literal docblock when an unresolved value is passed, add --literals option - #39
Open
TomasVotruba wants to merge 2 commits into
Open
TomasVotruba wants to merge 2 commits into
TomasVotruba wants to merge 2 commits into
Conversation
…--literals option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes around the
@param 'a'|'b'string literal docblock from #38.Fix: unresolved arguments now block the docblock
Arguments collect could not resolve (e.g. a variable) were dropped, so "only literals were passed" really meant "only literals among the resolvable calls". On mautic,
Download::setTrackingId()got@param '123456'|'13'|...from test values, whileAssetModelpasses a variable.Collect now records such arguments with an empty type. Aggregate ignores them for the native type, but they drop the literal docblock.
New
--literalsoptionargtyper add-types . --literalsOnly adds string types that come with the literal docblock, nothing else.
On mautic: 92 literal docblocks before the fix, 39 after.