Skip to content

Skip string literal docblock when an unresolved value is passed, add --literals option - #39

Open
TomasVotruba wants to merge 2 commits into
mainfrom
string-literal-unresolved-args
Open

TomasVotruba wants to merge 2 commits into
mainfrom
string-literal-unresolved-args

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Two changes around the @param 'a'|'b' string literal docblock from #38.

Fix: unresolved arguments now block the docblock

Arguments collect could not resolve (e.g. a variable) were dropped, so "only literals were passed" really meant "only literals among the resolvable calls". On mautic, Download::setTrackingId() got @param '123456'|'13'|... from test values, while AssetModel passes a variable.

Collect now records such arguments with an empty type. Aggregate ignores them for the native type, but they drop the literal docblock.

New --literals option

argtyper add-types . --literals

Only adds string types that come with the literal docblock, nothing else.

On mautic: 92 literal docblocks before the fix, 39 after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant