Fix crash when negating query with empty group#7234
Draft
rorbech wants to merge 2 commits into
Draft
Conversation
cmelchior
suggested changes
Dec 4, 2020
cmelchior
left a comment
cmelchior
left a comment
Contributor
There was a problem hiding this comment.
A few comments on how the tests are written + we do need a changelog entry for it.
| RealmResults<AllTypes> fives = realm.where(AllTypes.class) | ||
| .equalTo(AllTypes.FIELD_LONG, 5) | ||
| .beginGroup() | ||
| .endGroup() |
Contributor
There was a problem hiding this comment.
Doesn't this throw as well?
| assertEquals(1, fives.size()); | ||
| } | ||
|
|
||
| @Test (expected = UnsupportedOperationException.class) |
Contributor
There was a problem hiding this comment.
Generally, we only reserve this exception to things not implemented. A more appropriate exception would be IllegalStateException
Contributor
Author
There was a problem hiding this comment.
From documentation of the various RealmQuery methods it seems like invalid queries (syntax errors) are indicated by throwing UnsupportedOperationException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently just added tests for queries with empty groups
Closes #7233