Skip to content

. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glennawatson wants to merge 1 commit into from
Closed

. #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/ReactiveUI.Binding.SourceGenerators/CodeGeneration/InvokeCommandCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,16 @@ internal static List<InvokeCommandTypeGroup> GroupByTypeSignature(
/// <param name="features">The consumer compilation's language-feature snapshot.</param>
/// <remarks>
/// Call sites spelling the same selector reach the same worker, so the worker is keyed by the target type and
/// that text rather than by the call site. Under expression-text dispatch their branches are identical too,
/// and all but the first would be unreachable, so the group is collapsed to one call site per distinct
/// selector. Interception claims each call site by name, so nothing is collapsed there: a dropped call site
/// would carry no attribute and lose its generated invocation.
/// that text rather than by the call site. Whether the group also collapses to one of those call sites is the
/// snapshot's to say, because every API answers it the same way.
/// </remarks>
private static void EmitGroup(
StringBuilder sb,
InvokeCommandTypeGroup group,
ImmutableArray<ClassBindingInfo> allClasses,
in LanguageFeatures features)
{
var collapsible = features.SupportsCallerArgExpr && !features.SupportsInterceptors;
var emitted = collapsible
var emitted = features.CollapsesIndistinguishableCallSites
? group with
{
Invocations = CodeGeneratorHelpers.CollapseIndistinguishableCallSites(
Expand Down
Loading