Skip to content

fix(build): register interceptor namespaces through the InterceptorsNamespaces property #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennawatson merged 1 commit into from
Sep 14, 2026
Merged

fix(build): register interceptor namespaces through the InterceptorsNamespaces property #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/ReactiveUI.Binding.SourceGenerators/build/ReactiveUI.Binding.SourceGenerators.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@

<!--
Interception is refused outright for a namespace the project did not list, so the opt-in travels with
the generator that emits into it. Appended to whatever the project already listed, and written straight
into $(Features) because the friendly property was folded into it before this target runs.
the generator that emits into it. Appended to whatever the project already listed. The compiler task reads
the property when CoreCompile runs and merges it with the SDK's own namespaces; a second
InterceptorsNamespaces entry in $(Features) would replace that merged list instead.
-->
<PropertyGroup Condition="'$(_ReactiveUIBindingInterceptsCallSites)' == 'true' and '$(ReactiveUIBindingUseInterceptors)' == 'true'">
<_ReactiveUIBindingInterceptorsNamespaces>$(InterceptorsNamespaces)</_ReactiveUIBindingInterceptorsNamespaces>
<_ReactiveUIBindingInterceptorsNamespaces Condition="'$(_ReactiveUIBindingInterceptorsNamespaces)' != ''">$(_ReactiveUIBindingInterceptorsNamespaces);</_ReactiveUIBindingInterceptorsNamespaces>
<_ReactiveUIBindingInterceptorsNamespaces>$(_ReactiveUIBindingInterceptorsNamespaces)$(_ReactiveUIBindingInterceptorNamespace)</_ReactiveUIBindingInterceptorsNamespaces>
<Features>$(Features);InterceptorsNamespaces=$(_ReactiveUIBindingInterceptorsNamespaces)</Features>
<InterceptorsNamespaces>$(_ReactiveUIBindingInterceptorsNamespaces)</InterceptorsNamespaces>
</PropertyGroup>

<!--
Expand Down
Loading