refactor: isolate scheduler state and condense code comments - #211
Merged
glennawatson merged 11 commits intoSep 12, 2026
Merged
Conversation
- Replace delays, polling and thread rendezvous with awaited completion sources, virtual clocks and ordered calls into internal seams. - Add seams for stepwise dispatch: WasmScheduler.QueueReady and RunReadyBatch, so enqueue, dispose and drain are explicit steps. - Assert per-item dispatch counts where a total was checked before. - Trim documentation to the contract: concise summaries, inline notes at the confusing line, and remarks only for non-obvious behaviour. - Correct exception docs to the type thrown rather than the guard helper.
- Reduce internal operator and helper summaries to a single line of behaviour. - Drop allocation and deadlock rationale from field and method summaries. - Keep remarks for public contracts a caller cannot infer from the signature.
- Scale between ticks and monotonic timestamps without a double round trip, so a duration representable on both grids survives unchanged. - A 50-tick delay converted at a 10 MHz timestamp frequency no longer lands a tick late, which left scheduled work undue at its own due time.
- Replace placeholder parameter text with the role the argument plays. - Say which window a sequencer times, and which side an observer receives.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 99.10% 99.77% +0.66%
==========================================
Files 711 714 +3
Lines 22078 22219 +141
Branches 2703 2733 +30
==========================================
+ Hits 21881 22169 +288
+ Misses 196 49 -147
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
glennawatson
deleted the
refactor/deterministic-tests-and-concise-docs
branch
September 12, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What kind of change does this PR introduce?
What is the new behavior?
We removed the tests’ dependence on live sequencer state and timing because it was nondeterministic, causing the same code to pass on some runs and fail on others. Tests now control time and state transitions explicitly, making those cases repeatable and removing that source of flaky failures.
What is the current behavior?
What might this PR break?
Checklist
mainbranchAdditional information