Repository navigation
Add Maven toolchains support for vertx:run - #787
Merged
Merged
Conversation
Closes #100 When a JDK toolchain is configured, the forked Vert.x application now uses the toolchain JDK instead of the JDK running Maven. Falls back to existing java.home/JAVA_HOME resolution when no toolchain is configured. Replace class loading with ASM bytecode inspection in the launcher detection logic. The previous approach used `URLClassLoader.loadClass()` to walk the superclass hierarchy, which fails with `UnsupportedClassVersionError` when the user's code targets a higher JDK than the one running Maven (e.g. toolchain selects JDK 21 but Maven runs on JDK 11). Assisted-By: Claude Opus 4.6
tsegismont
force-pushed
the
toolchains
branch
from
October 13, 2026 15:55
fcdafd8 to
e550314
Compare
tsegismont
added a commit
to tsegismont/vertx-maven-plugin
that referenced
this pull request
Oct 13, 2026
Follows-up on reactiverse#787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100
When a JDK toolchain is configured, the forked Vert.x application now uses the toolchain JDK instead of the JDK running Maven. Falls back to existing java.home/JAVA_HOME resolution when no toolchain is configured.
Replace class loading with ASM bytecode inspection in the launcher detection logic. The previous approach used
URLClassLoader.loadClass()to walk the superclass hierarchy, which fails withUnsupportedClassVersionErrorwhen the user's code targets a higher JDK than the one running Maven (e.g. toolchain selects JDK 21 but Maven runs on JDK 11).Assisted-By: Claude Opus 4.6