Skip to content

Pass deploy secrets via env and apply instead of delete/create #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vcarl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass deploy secrets via env and apply instead of delete/create #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,25 +74,29 @@ jobs:
cat k8s-context

- name: Set up kubectl
uses: matootie/dokube@v1.4.0
uses: matootie/dokube@ee111b5817358e3e0439c58985a36c7d6a737a15 # v1.4.0
with:
personalAccessToken: ${{ secrets.DIGITALOCEAN_TOKEN }}
clusterName: k8s-rf

- name: Deploy app
# `|| echo \n` is to allow each of these steps to return non-zero exits
# I don't remember why that was valuable but I'm afraid to remove it
env:
DISCORD_HASH: ${{ secrets.DISCORD_HASH }}
DISCORD_PUBLIC_KEY: ${{ secrets.DISCORD_PUBLIC_KEY }}
DISCORD_APP_ID: ${{ secrets.DISCORD_APP_ID }}
GUILD_ID: ${{ secrets.GUILD_ID }}
GH_READ_TOKEN: ${{ secrets.GH_READ_TOKEN }}
AMPLITUDE_KEY: ${{ secrets.AMPLITUDE_KEY }}
REACTIBOT_API_KEY: ${{ secrets.REACTIBOT_API_KEY }}
OPENAI_KEY: ${{ secrets.OPENAI_KEY }}
run: |
kubectl diff -k . || echo \n
kubectl delete secret reactibot-env || echo \n
kubectl create secret generic reactibot-env \
--from-literal=DISCORD_HASH=${{ secrets.DISCORD_HASH }} \
--from-literal=DISCORD_PUBLIC_KEY=${{ secrets.DISCORD_PUBLIC_KEY }} \
--from-literal=DISCORD_APP_ID=${{ secrets.DISCORD_APP_ID }} \
--from-literal=GUILD_ID=${{ secrets.GUILD_ID }} \
--from-literal=GH_READ_TOKEN=${{ secrets.GH_READ_TOKEN }} \
--from-literal=AMPLITUDE_KEY=${{ secrets.AMPLITUDE_KEY }} \
--from-literal=REACTIBOT_API_KEY=${{ secrets.REACTIBOT_API_KEY }} \
--from-literal=OPENAI_KEY=${{ secrets.OPENAI_KEY }} \
|| echo \n
args=()
for k in DISCORD_HASH DISCORD_PUBLIC_KEY DISCORD_APP_ID GUILD_ID GH_READ_TOKEN AMPLITUDE_KEY REACTIBOT_API_KEY OPENAI_KEY; do
args+=("--from-literal=$k=${!k}")
done
kubectl create secret generic reactibot-env "${args[@]}" \
--dry-run=client -o yaml | kubectl apply -f - || echo \n
kubectl apply -k .
Loading