Repository navigation
[visual testing] open-example: Send the visual deep link once on iOS - #59994
Merged
Merged
Conversation
#59518 sends each visual example's deep link twice, so a slow Android emulator can't drop it before RNTester's JS Linking listener is registered. On iOS, each link raises an "Open in RNTester?" dialog and only one is accepted, so `border` fails its first attempt in every iOS capture job and leaves RNTester on the Border example. `button/default-styling/default` then captures that screen, which fails the iOS visual check on unrelated PRs. The second link is now sent on Android only. Changelog: [Internal]
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Nov 13, 2026
cortinico
enabled auto-merge (squash)
November 13, 2026 13:39
facebook-github-tools
Bot
added
the
Shared with Meta
robhogan
changed the title
robhogan
changed the title
robhogan
added a commit
that referenced
this pull request
Nov 14, 2026
On iOS, a single deep link can be dropped when it arrives before RNTester's JS Linking listener is registered, and a relaunch can restore the previous example instead, which has the same `example-container`. Since #59994 sent the link only once on iOS, 17 of 25 iOS capture jobs had a flow fail its first attempt this way. `open-example.yml` now takes the ID of an element only that example has, and relaunches and links again until it's visible, up to 3 times, so a missed link costs one relaunch rather than a whole flow retry. This drops the fixed 15-second wait between two links. Changelog: [Internal]
robhogan
added a commit
that referenced
this pull request
Nov 14, 2026
RNTester ignores a deep link until its JS has rendered, but `open-example.yml` only waited for animations to end, which happens about 1.4s after relaunch, before RNTester takes links (about 2.7s). Since #59994 sent the link once on iOS, 17 of 25 iOS capture jobs had a flow fail its first attempt this way. The helper now waits for the "Components" tab label, which RNTester's tab bar shows on every screen, then links once. It also takes the ID of an element only that example has, and relaunches and links again until it's visible, up to 3 times, since a relaunch can restore the previous example, which has the same `example-container`. Changelog: [Internal]
usama-liaqat
pushed a commit
to usama-liaqat/react-native
that referenced
this pull request
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59518 sends each visual example's deep link twice, so a slow Android emulator can't drop it before RNTester's JS
Linkinglistener is registered. On iOS though, each link raises an "Open in RNTester?" dialog and we only accept one. The second dialog makesborderfail its first attempt in every iOS capture job, leaving RNTester on the Border example, whichbutton/default-styling/defaultthen captures - eg #59888 (comment).This sends the second link on Android only.
Changelog: [Internal]
Test plan:
On a freshly erased iOS simulator, a single link opened the example cleanly 4/4 times, where two links reproduced the stale capture. This PR's own Test All run exercises the flows on CI -
bordershould pass first time on iOS andbutton/default-styling/defaultshould match the baseline.