Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
mym0404
marked this pull request as ready for review
October 9, 2026 16:29
facebook-github-tools
Bot
added
the
Shared with Meta
mym0404
changed the title
This was referenced Oct 27, 2026
Contributor
Author
|
Hi @cipolleschi, could you please review this iOS inline View alignment fix when you have a chance? Thank you! |
Contributor
Author
|
Hi @cortinico, could you please review this iOS inline View alignment fix when you have a chance? Thank you! |
cortinico
requested changes
Nov 13, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Can we add this reproduction to RNTester please?
Contributor
|
@mym0404 also pls fix merge conflicts |
Contributor
Author
|
@cortinico conflicts have been resolved. |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D131806404. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
iOS Fabric inline
<View>attachments use a fallback font and miss the baseline offset from an explicitlineHeight. Preserve the enclosing<Text>font on each attachment and subtractNSBaselineOffsetAttributeNamewhen positioning the View.The reproduction is included in RNTester under Text > Inline view baseline alignment, with ten samples, numeric alignment differences, and Dynamic Type. Direct link:
rntester://example/TextExample/inline-view-baseline.RNTester source-build results, commands, and measurements
Changelog:
[IOS] [FIXED] - Align inline Views with inherited fonts and explicit lineHeight.
Test Plan:
lineHeight: 48error is 10.293 pt before and -0.041 pt after. Maximum displayed error after the fix: 0.151 pt.yarn flow-check --max-workers 6) reported 0 errors. Prettier, ESLint, clang-format, and the PR diff's whitespace checks passed.Nested Text is checked visually because its public View measurement is unavailable.