Skip to content

Consolidate generated view config imports #58651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Consolidate generated view config imports #58651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions packages/babel-plugin-codegen/__tests__/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,13 @@ interface NativeCommands {
+hotspotUpdate: (viewRef: React.ElementRef<NativeType>, x: Int32, y: Int32) => void,
+scrollTo: (viewRef: React.ElementRef<NativeType>, y: Int32, animated: boolean) => void,
}
const {
ConditionallyIgnoredEventHandlers
} = require('react-native/unstable-internals-do-not-use');
const {
NativeComponentRegistry
} = require('react-native');
const {
Renderer
} = require(\\"react-native/unstable-internals-do-not-use\\");
ConditionallyIgnoredEventHandlers,
dispatchCommand
} = require('react-native/unstable-internals-do-not-use');
let nativeComponentName = 'RCTModule';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"RCTModule\\",
Expand Down Expand Up @@ -135,10 +133,10 @@ export const __INTERNAL_VIEW_CONFIG = {
export default NativeComponentRegistry.get(nativeComponentName, () => __INTERNAL_VIEW_CONFIG);
export const Commands = {
hotspotUpdate(ref, x, y) {
Renderer.dispatchCommand(ref, \\"hotspotUpdate\\", [x, y]);
dispatchCommand(ref, \\"hotspotUpdate\\", [x, y]);
},
scrollTo(ref, y, animated) {
Renderer.dispatchCommand(ref, \\"scrollTo\\", [y, animated]);
dispatchCommand(ref, \\"scrollTo\\", [y, animated]);
}
};"
`;
Expand All @@ -164,15 +162,13 @@ interface NativeCommands {
+hotspotUpdate: (viewRef: React.ElementRef<NativeType>, x: Int32, y: Int32) => void,
+scrollTo: (viewRef: React.ElementRef<NativeType>, y: Int32, animated: boolean) => void,
}
const {
ConditionallyIgnoredEventHandlers
} = require('react-native/unstable-internals-do-not-use');
const {
NativeComponentRegistry
} = require('react-native');
const {
Renderer
} = require(\\"react-native/unstable-internals-do-not-use\\");
ConditionallyIgnoredEventHandlers,
dispatchCommand
} = require('react-native/unstable-internals-do-not-use');
let nativeComponentName = 'RCTModule';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"RCTModule\\",
Expand Down Expand Up @@ -200,10 +196,10 @@ export const __INTERNAL_VIEW_CONFIG = {
export default NativeComponentRegistry.get(nativeComponentName, () => __INTERNAL_VIEW_CONFIG);
export const Commands = {
hotspotUpdate(ref, x, y) {
Renderer.dispatchCommand(ref, \\"hotspotUpdate\\", [x, y]);
dispatchCommand(ref, \\"hotspotUpdate\\", [x, y]);
},
scrollTo(ref, y, animated) {
Renderer.dispatchCommand(ref, \\"scrollTo\\", [y, animated]);
dispatchCommand(ref, \\"scrollTo\\", [y, animated]);
}
};"
`;
Expand Down
30 changes: 17 additions & 13 deletions ...gen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateViewConfigJs-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Map {
'use strict';

const {NativeComponentRegistry} = require('react-native');
const {processColorArray} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'ArrayPropsNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
Expand All @@ -27,7 +28,7 @@ export const __INTERNAL_VIEW_CONFIG = {
progress: true,
radii: true,
colors: {
process: require('react-native/unstable-internals-do-not-use').processColorArray
process: processColorArray
},
srcs: true,
points: true,
Expand Down Expand Up @@ -92,12 +93,13 @@ Map {
'use strict';

const {NativeComponentRegistry} = require('react-native');
const {colorAttribute} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'ColorPropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"ColorPropNativeComponentView\\",
validAttributes: {
tintColor: require('react-native/unstable-internals-do-not-use').colorAttribute
tintColor: colorAttribute
}
};
export default NativeComponentRegistry.get(nativeComponentName, () => __INTERNAL_VIEW_CONFIG);
Expand Down Expand Up @@ -210,8 +212,8 @@ Map {

'use strict';

const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');
const {NativeComponentRegistry} = require('react-native');
const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'EventNestedObjectPropsNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
Expand Down Expand Up @@ -252,8 +254,8 @@ Map {

'use strict';

const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');
const {NativeComponentRegistry} = require('react-native');
const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'EventPropsNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
Expand Down Expand Up @@ -358,14 +360,14 @@ Map {

'use strict';

const {NativeComponentRegistry} = require('react-native');
const {Image, NativeComponentRegistry} = require('react-native');

let nativeComponentName = 'ImagePropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"ImagePropNativeComponentView\\",
validAttributes: {
thumbImage: {
process: require('react-native').Image.resolveAssetSource
process: Image.resolveAssetSource
}
}
};
Expand Down Expand Up @@ -422,8 +424,8 @@ Map {

'use strict';

const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');
const {NativeComponentRegistry} = require('react-native');
const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'RCTInterfaceOnlyComponent';
export const __INTERNAL_VIEW_CONFIG = {
Expand Down Expand Up @@ -494,19 +496,20 @@ Map {

'use strict';

const {NativeComponentRegistry} = require('react-native');
const {Image, NativeComponentRegistry} = require('react-native');
const {colorAttribute, pointsDiffer} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'MultiNativePropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"MultiNativePropNativeComponentView\\",
validAttributes: {
thumbImage: {
process: require('react-native').Image.resolveAssetSource
process: Image.resolveAssetSource
},
color: require('react-native/unstable-internals-do-not-use').colorAttribute,
thumbTintColor: require('react-native/unstable-internals-do-not-use').colorAttribute,
color: colorAttribute,
thumbTintColor: colorAttribute,
point: {
diff: require('react-native/unstable-internals-do-not-use').pointsDiffer
diff: pointsDiffer
}
}
};
Expand Down Expand Up @@ -592,13 +595,14 @@ Map {
'use strict';

const {NativeComponentRegistry} = require('react-native');
const {pointsDiffer} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'PointPropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"PointPropNativeComponentView\\",
validAttributes: {
startPoint: {
diff: require('react-native/unstable-internals-do-not-use').pointsDiffer
diff: pointsDiffer
}
}
};
Expand Down
30 changes: 17 additions & 13 deletions ...degen/e2e/namespaced/__tests__/components/__snapshots__/GenerateViewConfigJs-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Map {
'use strict';

const {NativeComponentRegistry} = require('react-native');
const {processColorArray} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'ArrayPropsNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
Expand All @@ -27,7 +28,7 @@ export const __INTERNAL_VIEW_CONFIG = {
progress: true,
radii: true,
colors: {
process: require('react-native/unstable-internals-do-not-use').processColorArray
process: processColorArray
},
srcs: true,
points: true,
Expand Down Expand Up @@ -92,12 +93,13 @@ Map {
'use strict';

const {NativeComponentRegistry} = require('react-native');
const {colorAttribute} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'ColorPropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"ColorPropNativeComponentView\\",
validAttributes: {
tintColor: require('react-native/unstable-internals-do-not-use').colorAttribute
tintColor: colorAttribute
}
};
export default NativeComponentRegistry.get(nativeComponentName, () => __INTERNAL_VIEW_CONFIG);
Expand Down Expand Up @@ -210,8 +212,8 @@ Map {

'use strict';

const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');
const {NativeComponentRegistry} = require('react-native');
const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'EventNestedObjectPropsNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
Expand Down Expand Up @@ -252,8 +254,8 @@ Map {

'use strict';

const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');
const {NativeComponentRegistry} = require('react-native');
const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'EventPropsNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
Expand Down Expand Up @@ -358,14 +360,14 @@ Map {

'use strict';

const {NativeComponentRegistry} = require('react-native');
const {Image, NativeComponentRegistry} = require('react-native');

let nativeComponentName = 'ImagePropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"ImagePropNativeComponentView\\",
validAttributes: {
thumbImage: {
process: require('react-native').Image.resolveAssetSource
process: Image.resolveAssetSource
}
}
};
Expand Down Expand Up @@ -422,8 +424,8 @@ Map {

'use strict';

const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');
const {NativeComponentRegistry} = require('react-native');
const {ConditionallyIgnoredEventHandlers} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'RCTInterfaceOnlyComponent';
export const __INTERNAL_VIEW_CONFIG = {
Expand Down Expand Up @@ -494,19 +496,20 @@ Map {

'use strict';

const {NativeComponentRegistry} = require('react-native');
const {Image, NativeComponentRegistry} = require('react-native');
const {colorAttribute, pointsDiffer} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'MultiNativePropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"MultiNativePropNativeComponentView\\",
validAttributes: {
thumbImage: {
process: require('react-native').Image.resolveAssetSource
process: Image.resolveAssetSource
},
color: require('react-native/unstable-internals-do-not-use').colorAttribute,
thumbTintColor: require('react-native/unstable-internals-do-not-use').colorAttribute,
color: colorAttribute,
thumbTintColor: colorAttribute,
point: {
diff: require('react-native/unstable-internals-do-not-use').pointsDiffer
diff: pointsDiffer
}
}
};
Expand Down Expand Up @@ -592,13 +595,14 @@ Map {
'use strict';

const {NativeComponentRegistry} = require('react-native');
const {pointsDiffer} = require('react-native/unstable-internals-do-not-use');

let nativeComponentName = 'PointPropNativeComponentView';
export const __INTERNAL_VIEW_CONFIG = {
uiViewClassName: \\"PointPropNativeComponentView\\",
validAttributes: {
startPoint: {
diff: require('react-native/unstable-internals-do-not-use').pointsDiffer
diff: pointsDiffer
}
}
};
Expand Down
Loading
Loading