bump ndk r28c - #58650
Open
Kudo wants to merge 1 commit into
Open
bump ndk r28c#58650Kudo wants to merge 1 commit into
Kudo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
Contributor
Contributor
Is this the default coming with AGP 9.2.1? BTW we need to bump it inside docker-android also |
Contributor
Author
yes since it's the default on AGP 9.2.0 https://developer.android.com/build/releases/agp-9-2-0-release-notes#compatibility
thanks will follow up to create the docker-android pr. we also need to bump for hermes and fbjni though |
Kudo
added a commit
to Kudo/docker-android
that referenced
this pull request
Sep 23, 2026
Contributor
Author
docker-android pr at react-native-community/docker-android#253 |
Contributor
Yes true. Is this something you could help me with? 🙏 |
This was referenced Sep 24, 2026
Contributor
Author
here we go
|
meta-codesync Bot
pushed a commit
to facebookincubator/fbjni
that referenced
this pull request
Sep 24, 2026
Summary: ## Motivation for react-native ndk r28c bump react/react-native#58650. we should also align the dependencies for the libraries - bump agp to 9.2.1 - `./gradlew wrapper --gradle-version 9.4.1 --distribution-type all` to update gradle wrapper since apg requires newer gradle wrapper - bump ndk to r28c - remove deprecated `android.enableJetifier=true` Pull Request resolved: #119 Test Plan: - ci passed - check local aar and its *.so is built from ndk r28c Reviewed By: andrewdacenko Differential Revision: D121602025 Pulled By: cortinico fbshipit-source-id: 67e292527515ba7667dffb4885693679ed898406
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Sep 25, 2026
Summary: for react-native ndk r28c bump react/react-native#58650. we should also align the dependencies for the libraries ### Changes - bump agp to 9.2.1 - `./gradlew wrapper --gradle-version 9.4.1 --distribution-type bin` because agp 9 requires newer gradle wrapper - bump ndk to r28c - remove deprecated `android.enableJetifier=true` - update build.gradle.kts for agp 9 supported dsl Pull Request resolved: #2196 Test Plan: local build aar and verify *.so is built by ndk r28c Reviewed By: andrewdacenko Differential Revision: D121799383 Pulled By: cortinico fbshipit-source-id: f0fc24c92f70a73f914260f3a45232a5fa86f780
meta-codesync Bot
pushed a commit
to facebook/fresco
that referenced
this pull request
Sep 25, 2026
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `main` branch ## Motivation (required) for react-native ndk r28c bump react/react-native#58650. we should also align the dependencies for the libraries ### Changes - bump agp to 9.2.1 - `./gradlew wrapper --gradle-version 9.4.1 --distribution-type bin` because agp 9 requires newer gradle wrapper - bump ndk to r28c - remove `apply plugin: 'kotlin-android'` because agp 9 has builtin kotlin support - kapt to legacy-kapt - some dependencies updates because of `android.dependency.useConstraints` is false since agp 9 ## Test Plan (required) test aar build passed and verify the *.so is built by ndk r28c ## Next Steps Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the [Contributing guide][4]. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: http://circleci.com/gh/facebook/fresco [4]: https://github.com/facebook/fresco/blob/main/CONTRIBUTING.md Pull Request resolved: #2866 Reviewed By: Abbondanzo Differential Revision: D121799286 Pulled By: cortinico fbshipit-source-id: f9362ce26450358ef705939028e3ad0f2b83dcf5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
we now use AGP 9.2.1 which default ndk version is r28c. it would be good to synchronize the ndk version
28.2.13676358ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZEScmake flag for 16kb page size support. ndk r28 has the default 16kb page size supportChangelog:
[ANDROID] [CHANGED] - Bump NDK to r28c
Test Plan:
ci passed