Conversation
meta-cla
Bot
added
the
CLA Signed
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120529435. |
facebook-github-tools
Bot
added
p: Software Mansion
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 17, 2026
Summary: Pull Request resolved: react#58571 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D120529435
branch
from
September 17, 2026 16:14
c8aa62d to
0571c3e
Compare
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120528333
Summary: Add safe fallback cases to RendererCore enum conversions so public umbrella consumers compile with Apple's -Wswitch-default policy. Changelog: [Internal] Differential Revision: D120687424
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 18, 2026 14:07
0571c3e to
9bec0f0
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
cortinico
approved these changes
Sep 18, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled.
Changelog: [Internal]
Differential Revision: D120529435