Skip to content

Upgrade formatting to Prettier 3.10.0 (#2226) - #2226

Open
gkz wants to merge 1 commit into
mainfrom
export-D131782725
Open

gkz wants to merge 1 commit into
mainfrom
export-D131782725

Conversation

@gkz

@gkz gkz commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary:
X-link: react/react-native#60005

Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with noformat instead of reformatting its generated body.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D131782725

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2026
@meta-codesync

meta-codesync Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@gkz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131782725.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Metro review: Looks good

Risk: low · Commit: 5a5e416 · 6 commands run

This PR bumps the root Prettier devDependency from 3.9.4 to 3.10.0. In two untranspiled metro-file-map worker files, it drops the semicolon after a // prettier-ignore'd class field. Prettier 3.10 would otherwise move the ; in front of the Flow type comment (#plugins; /*: ... */), which detaches the comment from the field. Without the semicolon the field ends by ASI, because constructor follows on a new line. Flow, lint, a repo-wide format check and the worker tests all pass, and both files load in plain Node.

No findings.

Verified
  • ✅ node_modules/.bin/prettier --stdin-filepath packages/metro-file-map/src/worker.js < <base version of worker.js> — Prettier 3.10.0 rewrites the base line to #plugins; /*: ReadonlyArray<MetadataWorker> */, which explains why the semicolon was dropped
  • ✅ yarn prettier --check . — Whole repo is clean under 3.10.0
  • ✅ node -e "require('./packages/metro-file-map/src/worker.js'); require('./packages/metro-file-map/src/plugins/dependencies/worker.js')" — Both untranspiled files parse and load in Node without the semicolons
  • ✅ yarn eslint packages/metro-file-map/src/worker.js packages/metro-file-map/src/plugins/dependencies/worker.js
  • ✅ yarn jest --no-watchman packages/metro-file-map/src/__tests__/worker-test.js — 10 tests passed
  • ✅ yarn typecheck — Flow: No errors

Not run: No benchmark: this is a formatter devDependency bump plus two punctuation-only edits, with no runtime cost. The yarn.lock change swaps one devDependency version and adds no new packages. Changes to package.json and yarn.lock still need the usual Meta import.

Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call.

@meta-codesync meta-codesync Bot changed the title Upgrade development formatting to Prettier 3.10.0 Upgrade development formatting to Prettier 3.10.0 (#2226) Nov 13, 2026
meta-codesync Bot pushed a commit that referenced this pull request Nov 13, 2026
Summary:
X-link: react/react-native#60005


Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Differential Revision: D131782725
gkz added a commit to gkz/react-native that referenced this pull request Nov 13, 2026
Summary:

X-link: react/metro#2226

Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Differential Revision: D131782725
gkz added a commit to gkz/react-native that referenced this pull request Nov 13, 2026
Summary:

X-link: react/metro#2226

Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Differential Revision: D131782725
meta-codesync Bot pushed a commit that referenced this pull request Nov 13, 2026
Summary:
X-link: react/react-native#60005


Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Differential Revision: D131782725
gkz added a commit to gkz/react-native that referenced this pull request Nov 14, 2026
Summary:

X-link: react/metro#2226

Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D131782725
meta-codesync Bot pushed a commit that referenced this pull request Nov 14, 2026
Summary:
X-link: react/react-native#60005


Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D131782725
Summary:
X-link: react/react-native#60005


Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D131782725
gkz added a commit to gkz/react-native that referenced this pull request Nov 14, 2026
Summary:

X-link: react/metro#2226

Upgrade formatter dependencies and retained locks to Prettier 3.10.0, with the compatible CLI and source changes needed for a self-contained upgrade prefix. Preserve runtime behavior, Flow types and parser/style policy; exclude the retained Yjs bundle with `noformat` instead of reformatting its generated body.

Changelog: [Internal]

Reviewed By: panagosg7

Differential Revision: D131782725
@meta-codesync meta-codesync Bot changed the title Upgrade development formatting to Prettier 3.10.0 (#2226) Upgrade formatting to Prettier 3.10.0 (#2226) Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported needs-meta-import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants