remove duplicate definitions of startcall and displayincomingcall as …

[Irfanwani]

…react native is thorwing error with the latest version. When upgrading to the latest version of react native (0.76.1), I got this error that RNCallKeep is exporting two methods with same name (got this error for two methods, startCall and displayIncomingCall).

[mluksha]

It looks like reasonable changes. There is an error if a new architecture is enabled. React-native modules don't support function overloading. And the removed parts seem not to be used anyway in the index.js.

@Irfanwani Could you please remove the commented lines of code?
@manuquentin Could you please review? Let's move it to the next release.

[Irfanwani]

It looks like reasonable changes. There is an error if a new architecture is enabled. React-native modules don't support function overloading. And the removed parts seem not to be used anyway in the index.js.

@Irfanwani Could you please remove the commented lines of code? @manuquentin Could you please review? Let's move it to the next release.

Done @mluksha

[Irfanwani]

@mluksha these changes can be merged now. Please proceed

[mluksha]

@saghul Could you please review this PR?

[saghul]

@manuquentin any objections to landing this?

[devartwa]

Hello guys, is this going to be released soon?

[sultanmyrza]

Can confirm removing duplicate methods displayIncomingCall(String uuid, String number, String callerName) and startCall(String uuid, String number, String callerName) works.

Tested on:

• expo project with "newArchEnabled": true
• physical device Galaxy A60 (Android 11)
• package.json

"expo": "~53.0.17",
"react-native": "0.79.5",
"react-native-callkeep": "^4.3.16",
"@config-plugins/react-native-callkeep": "^11.0.0",

aka #816 looks good to me.

Who we should ping to merge this PR? @manuquentin?

[jhonbergmann]

Hi everyone.

When are you going to merge, please?

[saghul]

Ping @manuquentin

[jhonbergmann]

@manuquentin

[Irfanwani]

Can anyone please merge this PR? It is a small fix hanging from a long time now.

[yashwant-manchu]

Merge this PR Immediately, Still Today Same issue when Installed and Run