refactor: use renderable guards for pagination items - #721
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. Walkthrough升级 Changes分页渲染判定
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Pagination now consistently renders valid React content such as 0 and NaN while keeping default controls and accessibility behavior for non-renderable values. The change is ready to merge with no identified product-facing risk. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 4 4
Lines 331 332 +1
Branches 152 153 +1
=======================================
+ Hits 330 331 +1
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ct-component/pagination#721) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y7wzfKDBZLkYD6aCn8KWjf
说明
isReactRenderable统一判断翻页和跳转节点是否需要渲染0、NaN等有效 React 内容,并保留交互容器和无障碍属性@rc-component/util的最低版本提升到首次提供该 helper 的^1.13.0验证
npm run tscnpm test -- tests/itemRender.test.tsx --runInBandgit diff --check关联 ant-design/ant-design#59193
Summary by CodeRabbit