Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/hooks/useItemKey.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type * as React from 'react';
import { useEvent } from '@rc-component/util';
import * as React from 'react';
import type { RowKey } from '../List';

export default function useItemKey<T>(rowKey: RowKey<T>) {
return useEvent((item: T): React.Key =>
typeof rowKey === 'function' ? rowKey(item) : (item[rowKey] as React.Key),
return React.useCallback(
(item: T): React.Key =>
typeof rowKey === 'function' ? rowKey(item) : (item[rowKey] as React.Key),
[rowKey],
);
}
30 changes: 30 additions & 0 deletions tests/listy.behavior.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,36 @@ describe('Listy behaviors', () => {
expect(lastProps.data).toEqual([]);
});

it('updates virtual row keys when rowKey changes', () => {
const items = [{ id: 1, slug: 'first' }];
const itemRender = (item: (typeof items)[number]) => <div>{item.id}</div>;
const { rerender } = render(
<Listy
items={items}
rowKey="id"
itemHeight={20}
height={100}
itemRender={itemRender}
/>,
);

expect(MockedVirtualList.__getLastProps().data[0].taggedKey).toBe('item:1');

rerender(
<Listy
items={items}
rowKey="slug"
itemHeight={20}
height={100}
itemRender={itemRender}
/>,
);

expect(MockedVirtualList.__getLastProps().data[0].taggedKey).toBe(
'item:first',
);
});

it('wraps virtual items with item class', () => {
const { container } = renderList();

Expand Down
Loading