Detect Docker without spawning grep - #91
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Use /.dockerenv for cgroup-v2 containers, retain cgroup marker detection, and return a stable false when Linux metadata is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OS::Underlying.docker? currently shells out to grep and only recognizes cgroup paths containing docker. Docker using cgroup v2 can expose root membership such as 0::/, so the predicate returns false even inside the container; every call also creates a subprocess.
This checks /.dockerenv first, streams cgroup membership as a fallback, and returns false when Linux metadata is unavailable. It intentionally remains Docker-specific and does not classify Podman.
Verification
Changing non-Linux or unavailable results from nil to false makes the predicate consistently boolean.