Cache a negative POSIX capability probe - #88
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Windows cannot fork, each
OS.posix?call repeats the failing capability probe because||=never caches false. Return an already-computed false value, while still permitting a nil reset.Reproduction and verification
Ten stubbed Windows calls return false with one NotImplementedError probe rather than ten. Non-Windows returns true without forking. No subprocess was created by the capability repro.
RBENV_VERSION=4.0.6 rbenv exec rspec -Ilib -Ispec).Breaking-change notes
No API removal or new platform assumption. Like the existing true cache, a negative result is retained until explicitly reset to nil.