Preserve values and quoting when parsing os-release - #85
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NAME="a=b"was truncated toa;NAME=became nil; single quotes and shell escapes were not decoded; comments became keys. Split only at the first equals sign, accept assignment keys, remove matching outer quotes and decode the applicable escapes without evaluating shell input.Reproduction and verification
The os-release specification defines quoting, comment handling and literal assignments. The corpus includes 500 deterministic quoted values, embedded equals/quotes/backslashes, UTF-8, empty values, EOF and duplicate keys. Existing #48 changes release parsing too, but retains the lossy split/quote behavior; this PR does not duplicate its new APIs.
RBENV_VERSION=4.0.6 rbenv exec rspec -Ilib -Ispec).Breaking-change notes
Corrected values, empty strings and ignored comment/non-assignment lines may differ from the previous malformed results. This is a reader for valid os-release assignments, not a general shell parser or expansion engine.