Skip to content

fix: flush offline outbox after reconnect#43

Merged
rdlabo merged 1 commit into
mainfrom
fix/offline-reconnect-flush
Jul 26, 2026
Merged

fix: flush offline outbox after reconnect#43
rdlabo merged 1 commit into
mainfrom
fix/offline-reconnect-flush

Conversation

@rdlabo

@rdlabo rdlabo commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the network connectivity signal subscribed before offline sync initialization completes
  • automatically flush a durable pending outbox when connectivity returns
  • add a regression test for offline initialization followed by reconnect

Root cause

The reconnect effect short-circuited on the non-reactive initialized flag during its first run. Because it never read the connectivity signal, later network changes did not schedule the effect again.

Impact

Applications could preserve an offline mutation in the outbox but leave it pending indefinitely after reconnect, until another code path explicitly called flush().

Validation

  • npm run prebuild
  • npm test (all projects; kit 530 tests)
  • npm run lint
  • winecode live browser E2E: replica read → offline mutation → pending outbox → reconnect → exactly-once server confirmation

@netlify

netlify Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deploy Preview for rdlabo-ionic-angular-library ready!

Name Link
🔨 Latest commit edcbf71
🔍 Latest deploy log https://app.netlify.com/projects/rdlabo-ionic-angular-library/deploys/6a65f5f56373af00081dd43d
😎 Deploy Preview https://deploy-preview-43--rdlabo-ionic-angular-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdlabo
rdlabo marked this pull request as ready for review July 26, 2026 11:58
@rdlabo
rdlabo merged commit d1b5f13 into main Jul 26, 2026
12 checks passed

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant