feat(offline): bridge authenticated sessions#40
Merged
Conversation
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rdlabo
marked this pull request as ready for review
July 25, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createOfflineAuthBridgeto own the shared credential exchange → remote session preparation → access publication → transport resume lifecycle@rdlabo/ionic-angular-kit/offlineWhy
winecode and tipsys currently duplicate this lifecycle in
app.config.ts. The duplication is security-sensitive: a logout or account replacement during credential exchange, replica preparation, or transport resume must not publish or persist the old identity. The bridge centralizes those invariants while leaving product policy in callbacks.Backward compatibility
This change is additive. Existing
provideKitAuthhooks and directOfflineCoordinatorServicecallers are unchanged.authSubjectis required only for identities passed to the new bridge. Existing scope id0remains accepted for current tipsys compatibility.Product migration check
subjecttoauthSubject; its exchange/consent and alert logic remain product-ownedauthSessionand redirect data as additional typed identity fields, usesisIdentityCurrentfor Firebase object identity, and moves its post-resume redirect toonRemoteResumedValidation
npm run prebuildnpm test(all workspace projects; kit: 509 tests)npm run lintnpm run test:offline-types:nonstrictnpm run test:actionsgit diff --check