docs: clarify social authentication trust boundaries - #51
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
||
| const subject = await verifyGoogleIdentityToken(googleIdToken, GOOGLE_CLIENT_IDS); | ||
| // login: require active Google sign-in | ||
| if (!hasFirebaseProviderIdentity(userRecord, 'google.com', subject, true)) { |
Contributor
There was a problem hiding this comment.
🟥 ログイン例が未検証の値を認証済みトークンとして扱う
ログイン例はユーザーレコードを照合へ渡す（hasFirebaseProviderIdentity）ため、記載どおりの実装では認証済みトークンという前提が守られません。
Was this helpful? React with 👍 or 👎 to provide feedback.
npm beta publishedCI passed for the merge commit npm install @rdlabo/workers-hono-kit@0.12.3-beta.pr51.sha3289ea609bb4 @rdlabo/workers-timezone@0.12.3-beta.pr51.sha3289ea609bb4 @rdlabo/workers-mysql@0.12.3-beta.pr51.sha3289ea609bb4 drizzle-orm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the verified Firebase identity prerequisite, provider subject matching, audience validation, and sign-in-provider policy for the shared Apple and Google helpers. Application-specific login/link policy remains with consumers. Validation: typecheck, lint, and all 508 tests passed.