fix: allow nested content in Ionic item groups - #35
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
npm beta publishedCI passed for the merge commit npm install @rdlabo/eslint-plugin-rules@22.1.0-beta.pr35.shab1091f1ba25f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require-ion-item-grouprejected already-grouped content such asion-list > ion-item-group > ion-accordion-group > ion-accordion > ion-item. Restructuring the UI to satisfy the rule split a single visual group and changed its spacing and rounded corners.Check for a supported group between each item and its nearest enclosing list instead of requiring an exact ancestor depth. Allow nested accordions and rendered wrappers while continuing to report missing groups, including inside nested lists. Preserve the existing conservative autofix behavior.
Validation:
npm run lintpassed.npm testpassed: 30 suites, 628 tests.