Rebase - #45
Open
anaswaragk wants to merge 171 commits into
Open
Conversation
Reason for change: compare and rebase Test Procedure: Regression test Risks: Medium Signed-off-by:krithika_venkataraman@comcast.com
Reason for change: new attribute test and minor python standard cleanup Test Procedure: Ensure L2 tests run as expected on ubuntu Risks: Low Signed-off-by:krithika_venkataraman@comcast.com
RDKEMW-4206 : Upstream LGI subtec changes
Reason for change: Modify y calculation logic when font size for each row differs Test Procedure: Play sarnoff stream and check Risks: Low Signed-off-by:Anaswara KookkalAnaswara_Kookkal@comcast.com
RDKEMW-4412: TTML attribute tests update to subtec L2 framework
RDKEMW-7101 : Sarnoff issue
Release version 1.4.0 changes with LGI upstream LGI upstream changes integrated in subtec code
Deploy cla action
Reason for change: change subttxrend graphics to 720p instead of 1080p Test Procedure: validate cc/ttml/webvtt, sarnoff test cases Priority: P1 Risks: Low Signed-off-by: Tony Paul <Tony_Paul@comcast.com>
Deploy fossid_integration_stateless_diffscan_target_repo action
Update CODEOWNERS
Reason for change: Modify cc position calculation logic Test Procedure: validate cc/ttml/webvtt, sarnoff test cases Risks: Low Signed-off-by: Anaswara KookkalAnaswara_Kookkal@comcast.com
Reason for change: Modify cc position calculation logic Test Procedure: validate cc/ttml/webvtt, sarnoff test cases Risks: Low Signed-off-by: Anaswara KookkalAnaswara_Kookkal@comcast.com
Reason for change: Modify cc position calculation logic Test Procedure: validate cc/ttml/webvtt, sarnoff test cases Risks: Low Signed-off-by: Anaswara KookkalAnaswara_Kookkal@comcast.com
RDKEMW-2465:720p graphics for Subttxrend instead of 1080p
RDKEMW-2465 Reduce the graphics surface size to 1280x720
RDKEMW-19878 : Fix coverity warnings in subttxrend-ctrl
RDKEMW-19891 : Fix coverity warnings in subttxrend-common
| @@ -92,9 +93,8 @@ set_property(TARGET ${LIBRARY_NAME} PROPERTY CXX_STANDARD 14) | |||
| set_property(TARGET ${LIBRARY_NAME} PROPERTY VERSION 0.0.0) | |||
| set_property(TARGET ${LIBRARY_NAME} PROPERTY SOVERSION 0) | |||
| set_property(TARGET ${LIBRARY_NAME} PROPERTY PUBLIC_HEADER ${SUBTTXREND_SCTE_PUBLIC_HEADERS}) | |||
| target_link_libraries(${LIBRARY_NAME} ${LIBSUBTTXRENDCOMMON_LIBRARIES}) | |||
| target_link_libraries(${LIBRARY_NAME} ${LIBSUBTTXRENDGFX_LIBRARIES}) | |||
RDKEMW-19940 : Fix coverity warnings in subttxrend-app
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RDKEMW-20652 : Fix coverity issues (from copilot) in subttxrend-testapps
|
|
||
| public: | ||
| void testGetConfigFractionalReturnsDefault() { | ||
| subttxrend::common::ConfigProvider stub; |
RDKEMW-20653 : Fix coverity issues (from copilot) in subttxrend-socksrc
RDKEMW-22974 : Fix coverity issues (from copilot) in subttxrend-webvtt
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The PR spans many components/build systems and includes confirmed crash/linking risks (null header deref in release builds, missing library link deps, and a broken pytest hook signature).
Review details
- Files reviewed: 42/415 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+124
to
128
| set_property(TARGET ${LIBRARY_NAME} PROPERTY CXX_STANDARD 14) | ||
| set_property(TARGET ${LIBRARY_NAME} PROPERTY VERSION 0.0.0) | ||
| set_property(TARGET ${LIBRARY_NAME} PROPERTY SOVERSION 0) | ||
| set_property(TARGET ${LIBRARY_NAME} PROPERTY PUBLIC_HEADER ${SUBTTXREND_DBUS_PUBLIC_HEADERS}) | ||
| target_link_libraries(${LIBRARY_NAME} ${LIBSUBTTXRENDCOMMON_LIBRARIES}) | ||
| target_link_libraries(${LIBRARY_NAME} ${LIBJANSSON_LIBRARIES}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.