RDKEMW-21913 : Fix coverity issues (from copilot) in subttxrend-dbus - #100
Open
krithikasvraman wants to merge 1 commit into
Open
RDKEMW-21913 : Fix coverity issues (from copilot) in subttxrend-dbus#100krithikasvraman wants to merge 1 commit into
krithikasvraman wants to merge 1 commit into
Conversation
Reason for change: Fix coverity issues in subttxrend-dbus Test Procedure: Regression tests Risks: Low Signed-off-by:krithika_venkataraman@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes Coverity-reported issues in the subttxrend-dbus component by correcting a Jansson json_pack format string and ensuring GError objects are properly logged and freed on DBus interface export failures.
Changes:
- Fixes an invalid Jansson
json_packformat string for the subtitle status response encoding. - Enhances DBus export failure logging to include the underlying
GErrormessage when present. - Frees
GErroron DBus export failure paths to avoid leaks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| subttxrend-dbus/src/JsonHelper.cpp | Fixes the JSON packing format string so the status response encodes correctly. |
| subttxrend-dbus/src/DbusHandlerTeletext.cpp | Logs GError details on export failure and frees GError before cleanup/return. |
| subttxrend-dbus/src/DbusHandlerSubtitles.cpp | Logs GError details on export failure and frees GError before cleanup/return. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fix coverity issues in subttxrend-dbus
Test Procedure: Regression tests
Risks: Low
Signed-off-by:krithika_venkataraman@comcast.com