RDKEMW-24854: Remove active scan on DeepSleep wake-up - #352
Conversation
Removed active WiFi scan trigger when waking from DeepSleep.
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted removal that matches the PR intent and does not introduce new logic or interfaces.
Pull request overview
This PR updates the DeepSleep wake-up handling in NetworkManagerImplementation to stop triggering an active WiFi scan when waking with Network Standby enabled, aligning wake behavior with the stated requirement to remove the rescan request.
Changes:
- Removed the DeepSleep wake-up call to
StartWiFiScan()(and its associated logging/error handling) fromOnPowerModeChanged. - Preserved existing DHCP lease reacquisition behavior for
wlan0andeth0on wake.
File summaries
| File | Description |
|---|---|
| plugin/NetworkManagerImplementation.cpp | Removes active WiFi scan trigger on DeepSleep wake while keeping DHCP reacquire logic intact. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Reason for change: Remove rescan request upon wake-up(NSM-ON).
Priority: P1
Test Procedure: Refer ticket
Risks: Low
Signed-off-by: Jaladi djalad690@cable.comcast.com