Skip to content

RDKEMW-24854: Remove active scan on DeepSleep wake-up - #352

Open
DevikaJaladi wants to merge 1 commit into
support/3.6.0from
topic/RDKEMW-24854
Open

RDKEMW-24854: Remove active scan on DeepSleep wake-up#352
DevikaJaladi wants to merge 1 commit into
support/3.6.0from
topic/RDKEMW-24854

Conversation

@DevikaJaladi

Copy link
Copy Markdown
Contributor

Reason for change: Remove rescan request upon wake-up(NSM-ON).
Priority: P1
Test Procedure: Refer ticket
Risks: Low

Signed-off-by: Jaladi djalad690@cable.comcast.com

Removed active WiFi scan trigger when waking from DeepSleep.
Copilot AI lite review requested due to automatic review settings September 10, 2026 19:39
@DevikaJaladi
DevikaJaladi requested a review from a team as a code owner September 10, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, targeted removal that matches the PR intent and does not introduce new logic or interfaces.

Pull request overview

This PR updates the DeepSleep wake-up handling in NetworkManagerImplementation to stop triggering an active WiFi scan when waking with Network Standby enabled, aligning wake behavior with the stated requirement to remove the rescan request.

Changes:

  • Removed the DeepSleep wake-up call to StartWiFiScan() (and its associated logging/error handling) from OnPowerModeChanged.
  • Preserved existing DHCP lease reacquisition behavior for wlan0 and eth0 on wake.
File summaries
File Description
plugin/NetworkManagerImplementation.cpp Removes active WiFi scan trigger on DeepSleep wake while keeping DHCP reacquire logic intact.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants