RDKEMW-24855: Remove active scan on DeepSleep wake-up - #351
Open
DevikaJaladi wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward removal of a wake-up scan call with no apparent side effects on build correctness or control flow in the modified hunk.
Pull request overview
This PR removes the WiFi active scan that was previously triggered when waking from DeepSleep (with Network Standby ON), leaving the wake-up flow to proceed directly to DHCP lease reacquisition.
Changes:
- Removed the DeepSleep wake-up
StartWiFiScan()call and its associated logging/commentary. - Kept the existing behavior of reacquiring DHCP leases for
wlan0andeth0upon wake from DeepSleep.
File summaries
| File | Description |
|---|---|
| plugin/NetworkManagerImplementation.cpp | Removes the active WiFi scan on DeepSleep wake-up, retaining DHCP lease reacquisition behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove rescan request upon wake-up(NSM-ON).
Priority: P1
Test Procedure: Refer ticket
Risks: Low
Signed-off-by: Jaladi djalad690@cable.comcast.com