RDKEMW-15910: bcm bb/bbappend analysis for sysint

[Abhinavpv28]

No description provided.

[Copilot]

Pull request overview

This PR updates the Yocto image recipe to add a new rootfs postprocess step that prefers vendor-provided “legacy entos” properties/scripts and otherwise falls back to the generic middleware versions.

Changes:

• Appends a new legacy_entos_support_patch hook to ROOTFS_POSTPROCESS_COMMAND.
• Adds a legacy_entos_support_patch() postprocess function to remove generic files when vendor versions exist, or rename generic files into place otherwise.

Comments suppressed due to low confidence (2)

recipes-images/rdk-fullstack-image.bb:67

• In the else branch, mv runs whenever imageFlasher.sh is missing, but it doesn’t verify that imageFlasher_generic.sh exists. If neither script is present, this will fail the postprocess step. Add a source-file existence check (and/or a warning) before attempting the rename.

    if [ -f "${IMAGE_ROOTFS}/lib/rdk/imageFlasher.sh" ]; then
        rm -f ${IMAGE_ROOTFS}/lib/rdk/imageFlasher_generic.sh
    else
        mv ${IMAGE_ROOTFS}/lib/rdk/imageFlasher_generic.sh ${IMAGE_ROOTFS}/lib/rdk/imageFlasher.sh
    fi

recipes-images/rdk-fullstack-image.bb:73

• Similarly, the else branch renames init-zram_generic.sh without checking it exists. If both the vendor and generic scripts are absent, mv will fail and can break image creation. Please guard with a -f check (and/or warn) before renaming.

    if [ -f "${IMAGE_ROOTFS}/lib/rdk/init-zram.sh" ]; then
        rm -f ${IMAGE_ROOTFS}/lib/rdk/init-zram_generic.sh
    else
        mv ${IMAGE_ROOTFS}/lib/rdk/init-zram_generic.sh ${IMAGE_ROOTFS}/lib/rdk/init-zram.sh
    fi    

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[svc-rdkeportal01]

CCI-Build-Verified +1
sha: cc9a8ee

[svc-rdkeportal01]

CCI-Build-Verified -1
sha: cc9a8ee

[svc-rdkeportal01]

CCI-Build-Verified -1
sha: cc9a8ee

[svc-rdkeportal01]

CCI-Build-Verified -1
sha: cc9a8ee

[svc-rdkeportal01]

CCI-Test-Verified -1
sha: cc9a8ee

[svc-rdkeportal01]

CCI-Build-Verified +1
sha: cc9a8ee

[svc-rdkeportal01]

CCI-Test-Verified +1
sha: cc9a8ee

[github-advanced-security]

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

• The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
• Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
• You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

[svc-rdkeportal01]

CCI-Build-Verified +1
sha: 00b1aed

[svc-rdkeportal01]

CCI-Build-Verified +1
sha: 00b1aed

[svc-rdkeportal01]

CCI-Test-Verified +1
sha: 00b1aed

[svc-rdkeportal01]

CCI-Test-Verified +1
sha: 00b1aed

[svc-rdkeportal01]

CCI-Build-Verified -1
sha: 00b1aed

[svc-rdkeportal01]

CCI-Build-Verified -1
sha: 00b1aed