RDKB-67080: Updating build_native.sh for configure args - #76
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Configure arguments need expansion, and the new section needs documentation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds support for reading and forwarding [CONFIGURE] arguments from configure_options.conf to Autotools builds.
Changes:
- Parses configure arguments.
- Logs and passes them to
./configure.
Review findings:
- Moderate (4 votes): Expand parsed arguments before forwarding them.
- Nit (1 vote): Document the new section and one-argument-per-line format.
| File | Description |
|---|---|
cov_docker_script/build_native.sh |
Adds configure-argument parsing and invocation support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nithishkumar-T
changed the title
GoutamD2905
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-67080: Updating build_native.sh for configure args
Reason for change: To include confgure args while compiling native build.
Test Procedure: All checks should pass.
Risks: Low
Priority: P1
Signed-off-by:Nithishkumar_Thirumoorthi@comcast.com