Updating build_native.sh for configuring extra arguments. - #75
Closed
Nithishkumar-T wants to merge 1 commit into
Closed
Nithishkumar-T wants to merge 1 commit into
Nithishkumar-T wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
configure_args is ignored when configure_options_file is set, and the new file section is undocumented.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds support for passing extra Autotools configure arguments from configuration files or JSON.
Changes:
- Parses
[CONFIGURE_ARGS]entries. - Supports JSON
configure_args. - Forwards arguments to
./configure.
| File | Summary |
|---|---|
cov_docker_script/build_native.sh |
Adds configure-argument parsing and invocation support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+268
to
+278
| local arg_count | ||
| arg_count=$(jq -r '.native_component.build.configure_args // [] | length' "$CONFIG_FILE") | ||
|
|
||
| i=0 | ||
| while [[ $i -lt $arg_count ]]; do | ||
| local configure_arg | ||
| configure_arg=$(jq -r ".native_component.build.configure_args[$i]" "$CONFIG_FILE") | ||
| configure_arg=$(expand_path "$configure_arg") | ||
| CONFIGURE_ARGS+=("$configure_arg") | ||
| i=$((i + 1)) | ||
| done |
Nithishkumar-T
force-pushed
the
feature/update_build_native
branch
from
September 24, 2026 10:05
11956d6 to
670df35
Compare
Comment on lines
+176
to
+178
| CONFIGURE_ARGS) | ||
| line="${line//\$HOME/$HOME}" | ||
| CONFIGURE_ARGS+=("$line") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.