[rcore][GLFW] Fix borderless-windowed mode being always on top#5868
[rcore][GLFW] Fix borderless-windowed mode being always on top#5868auwsmit wants to merge 1 commit into
borderless-windowed mode being always on top#5868Conversation
Don't pass a monitor to glfwSetWindowMonitor(). This avoids setting the flag which keeps the window always on top.
borderless-windowed mode being always on top
|
@auwsmit This is a sensible change, have you tested it on Windows, Linux, macOS and with multiple monitors and multiple DPIs? |
borderless-windowed mode being always on topborderless-windowed mode being always on top
|
@raysan5 Testing on Linux, it does create a problem where the taskbar stays on top of the borderless window (at least for my laptop with wayland and KDE). So is the best approach to do an Also sorry about closing the other issue and making this one. I realize in retrospect I probably should've just modified the old PR with a new commit and didnt have to close it and make this new one, but now I know not to that in the future. |
|
As I commented, this is a sensible change, it should be tested on a multi-monitor configuration and with different DPI monitors, I think the change can impact current behaviour, for example have you tried opening the window from a different working monitor instead of primary monitor? because I think that NULL always uses primary instead of current... |
Don't pass a monitor to
glfwSetWindowMonitor(). This avoids setting the flag internal to glfw which keeps the window always on top.BorderlessWindowed still works fine, and is properly detected on my two monitors at different resolutions.
Addresses this issue: #5854, but only for borderless FS.
A workaround for regular aka "exclusive" Fullscreen is mentioned in that thread, just add this to raylib's loop: