Make the panel tile grid a parameter - #105
Closed
rasros wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded: rather than make the grid configurable, the tiling is being removed outright. See the follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The panel cuts every picture into a
GRID x GRIDlattice, embeds each cell, and averages the 25 cell distances into one number per member. That average is what makes small features invisible: a change confined to one cell is divided by 25.Measured on duck-v14's eye, which the run drew with its polarity inverted (white disc, dark crescent, against the target's black pupil with a white rim highlight). Hand-correcting the two fills and rescoring:
At the current grid of 5 the eye's bounding box is 11.8% of one 140px cell and straddles a cell boundary, so it is roughly 0.5% of the score surface — which is where the per-member deltas land, at ±0.0005 on distances of 0.036 to 0.096. The three members are near-tied and a 2–1 split decides it.
Caveat this does not settle: both drawings are wrong in different ways, so "which wrong is closer" is a judgement call, and this is one hand-edited pair on one target. It is a reason to be able to vary the grid, not yet a reason to change its default.
What
GRIDwas a module constant read by_tiles. It is now a parameter:_tiles(image, grid), wheregrid <= 1returns the picture itselfEnsembleScorer(grid=...), threaded throughget_scorer, the runner, andmain--panel-grid N, defaulting to the existing 5No behaviour changes unless the flag is passed.
Tests
Two added: a grid of 1 hands the members the whole picture and 5 gives 25 cells; a grid's tiles cover the picture without overlap. Full suite green at 642.