media/hevc_d: Improve checking and cleanup of decoder - #7583
Open
jc-kynesim wants to merge 1 commit into
Open
Conversation
6by9
reviewed
Sep 1, 2026
6by9
left a comment
6by9
left a comment
Contributor
There was a problem hiding this comment.
Two very minor nits as I know they'd get flagged upstream.
A number of fixes and cleanup - many Claude inspired. Optimise guessing of new PU/Coeff buffers is we have already had to reallocate in this context. Fix buffer size roundup code so it rounds up as intended rather than to twice that amount. Reset slot tracking on streamoff so it doesn't become fatally confused if a second run is started before closing the context. Fix accounting for size of scaling factor list when alloocating command buffers. Previously would over allocate a bit. A number of fixes to decoder cleanup on release or probe error where structures could be leaked or were freed in the wrong order. Fix typo and pointless && clause in Kconfig Collocated ref index was bounds checked against the wrong value, potentially ending up with feeding random addresses to the h/w. Many more slice header and PPS parameters checked that could potentially misprogram the hardware. Generaly tidy and remove dead code and structures. Signed-off-by: John Cox <jc@kynesim.co.uk>
jc-kynesim
force-pushed
the
dev/6.18/hevc_dec_valid_3
branch
from
September 1, 2026 15:38
5fb97cb to
ad2f32c
Compare
6by9
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of fixes and cleanup - many Claude inspired.
Optimise guessing of new PU/Coeff buffers is we have already had to reallocate in this context.
Fix buffer size roundup code so it rounds up as intended rather than to twice that amount.
Reset slot tracking on streamoff so it doesn't become fatally confused if a second run is started before closing the context.
Fix accounting for size of scaling factor list when alloocating command buffers. Previously would over allocate a bit.
A number of fixes to decoder cleanup on release or probe error where structures could be leaked or were freed in the wrong order.
Fix typo and pointless && clause in Kconfig
Collocated ref index was bounds checked against the wrong value, potentially ending up with feeding random addresses to the h/w.
Many more slice header and PPS parameters checked that could potentially misprogram the hardware.
Generaly tidy and remove dead code and structures.