Repository navigation
feat(assistant): improve document workflows and request feedback - #270
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
2b3689e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8f41bfc.document-7hm.pages.dev |
| Branch Preview URL: | https://feat-assistant-experience.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE]
The assistant now offers tasks for the current document, distinguishes reusable drafts from ordinary or interrupted answers, and makes review and waiting states easier to understand. Commits remain separated by function as requested.
Summary
Risk Analysis
Design Decisions
Code Concerns
No outstanding actionable findings from specification and code-quality review. Verified findings were corrected before final integration.
Verification
Conclusion basis: Verified
pnpm exec vitest run --maxWorkers=2: 5,448 tests passed in 187 files.pnpm run lint:ts, repository format check and productionpnpm run build: passed. Final documentation formatting andgit diff --checkalso passed.Conclusion basis: Inferred from code, not measured on the user's hardware
Ordinary browser-local questions still classify intent before generating an answer, and context capture can attach up to 8,000 document characters. Reducing repeated inference and selecting context are separate follow-up work.
Not covered
Physical microphone behavior, manual screen-reader/high-zoom acceptance, actual WebGPU/CPU first-token latency and model answer quality. Provider responses and speech events are controlled in browser tests.
See experience review and acceptance.