Repository navigation
fix(assistant): restore follow-ups and refine history and voice - #268
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
23d999f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15cee029.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-assistant-stop-reuse.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stopping a browser-local assistant response could make every later question fail: WebLLM retained its interruption flag and returned empty content during the next JSON routing request. Use the SDK streaming path for all WebLLM calls, collect complete results for chat/JSON callers, and preserve tool IDs, usage and cancellation cleanup.
r-popoverfor explanations, retain icons, and keep the transcript editable with explicit Send and cancellation.Commits
46b3c77— Stop/follow-up recovery and SDK regression coverage.641226c— Searchable conversation browsing and safe data management.23d999f— Stable voice controls and timed explanations.Validation
Regression evidence: restoring the original WebLLM provider makes both installed-SDK Stop/follow-up cases fail with empty JSON. The SDK test uses real generation/cancellation control flow with a synthetic GPU boundary. Removing history filtering makes the search regression fail. Speech geometry reproduced a 46.375px composer expansion before the fix.
Review and limits
Independent review identified and resolved streamed Hermes tool IDs and hidden history deletion errors. Browser E2E uses real editor frames and controlled speech events/loopback responses. Physical microphone transcription, OS permission prompts and physical GPU inference/Worker latency are not claimed as verified.