fix(runtime): route SifSetReg and SifGetReg syscalls - #240
Open
hedgeg0d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispatcher never routed syscalls 0x79 and 0x7A, so SifSetReg and SifGetReg calls fell through to the TODO stub and always returned 0. Both implementations already exist in the SIF stubs, they were just never wired up.
Katamari Damacy needs these during boot: it polls SIF register 4 (IOP boot status) through SifGetReg and spins forever when it gets 0 back.
Adds a regression test that writes a SIF register with SifSetReg and reads it back with SifGetReg.