Skip to content

Correct TEXCLUT addressing for CSM1 and CSM2 - #231

Open
GTTeancum wants to merge 1 commit into
ran-j:mainfrom
GTTeancum:codex/gs-texclut-coordinates
Open

Correct TEXCLUT addressing for CSM1 and CSM2#231
GTTeancum wants to merge 1 commit into
ran-j:mainfrom
GTTeancum:codex/gs-texclut-coordinates

Conversation

@GTTeancum

Copy link
Copy Markdown

Summary

  • ignore TEXCLUT coordinates for CSM1's fixed CLUT layout
  • apply TEXCLUT only to CSM2 lookups
  • interpret CSM2 COU in its documented 16-pixel units
  • cover CSM1 and CSM2 independently with regression tests

Rationale

The CPU sampler applied CBW, COU, and COV to both CLUT storage modes and treated COU as a pixel offset. CSM1 does not use TEXCLUT; CSM2 uses COU << 4 and COV to address its source rectangle.

Tests

  • built ps2x_tests successfully with MSVC
  • MINITEST_FILTER=PS2GS: both new tests pass
  • the instrumented game-development checkout has one unrelated pre-existing CSR test failure; this branch is based directly on pristine upstream main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant