Skip to content

tag-helpers: drop the TODO about Omit credentials for HTMX 1.9.x and 2.x #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 1 commit into from
Oct 28, 2026
Merged

tag-helpers: drop the TODO about Omit credentials for HTMX 1.9.x and 2.x #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Ramstack.HtmxToolkit/TagHelpers/HtmxRequestTagHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,7 @@ internal readonly struct HtmxRequestDataPrior(HtmxRequestData data)
{
HtmxRequestCredentials.SameOrigin => false,
HtmxRequestCredentials.Include => true,
// TODO: Consider throwing an exception when an HTMX 4-only credentials mode is configured for HTMX 1.9.x or 2.x.
// HtmxRequestCredentials.Omit => throw new InvalidOperationException(),
// XMLHttpRequest always sends credentials to the same origin, so Omit has no equivalent.
_ => null
};

Expand Down
Loading