Accept vic3 format alias for save commands#56
Merged
Conversation
The melt command documents vic3 as a valid --format value, but only the v3 extension alias parsed successfully. This made explicit Vic3 melting fail before the save file was read. Keep v3 working and accept vic3 so the documented option reaches the existing Vic3 melter. Co-authored-by: Codex <noreply@openai.com>
The watch command help documents vic3 as a valid --format value, but the parser only accepted the v3 file extension spelling. Accept the documented alias while keeping v3 extension inference unchanged. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept
vic3anywhere the CLI help already documents it as a valid--formatvalue.This fixes a mismatch where
melt --format vic3andwatch --format vic3failed during argument parsing even though the help text listedvic3. The existingv3extension spelling remains supported.Validation
rustfmt --check src/melt.rs src/watch.rscargo test vic3_format_aliases_parsecargo test --binscargo run --quiet -- melt --format vic3 --unknown-key ignore --out ... Qing_Start.v3Full integration tests were not run locally because this checkout does not include the private token assets that upstream CI injects.
AI assistance: implementation and PR description were materially assisted by Codex.