extract unauthorized-from FlowTransferV1 helpers#459
Conversation
Three negative-path tests in Flow.transfer.t.sol built two-element FlowTransferV1 structs inline, with the same shape (one transfer unauthorized + one self-flow) repeated per token type. Adds three helpers in FlowTransferOperation.sol: - unauthorizedERC20Flow - unauthorizedERC721Flow - unauthorizedERC1155Flow Each takes the unauthorized address, the authorized actor, the flow, and per-type ids/amounts, and returns the full FlowTransferV1. The matching inline blocks in the three negative-path tests are replaced. The second block in the ERC20 test (where the unauthorized address is at slot 1, not 0) keeps its inline construction since it exercises a different shape. Closes #421. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 12 minutes and 36 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed 9e0082c: reviewed and approved. LGTM. |
…unauthorized-transfer-helpers # Conflicts: # test/src/concrete/Flow.transfer.t.sol
1 participant
Summary
Three negative-path tests in
Flow.transfer.t.solbuilt two-elementFlowTransferV1structs inline with the same shape (one transfer unauthorized + one self-flow) repeated per token type.Adds three helpers in
FlowTransferOperation.sol:unauthorizedERC20FlowunauthorizedERC721FlowunauthorizedERC1155FlowEach takes the unauthorized address, the authorized actor, the flow, and per-type ids/amounts, and returns the full
FlowTransferV1.The matching inline blocks in the three negative-path tests are replaced. The second block in the ERC20 test (unauthorized at slot 1, not 0) keeps its inline construction since it exercises a different shape.
Closes #421.
Test plan
🤖 Generated with Claude Code