ci: sign release DMG for the curl-based installer#242
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a signing step to the release workflow so each release publishes a detached signature for
Thuki.dmg. This is the release-side half of the upcoming one-line installer (curl -fsSL https://thuki.app/install.sh | sh), which downloads the DMG over HTTPS and verifies it before installing, so users get a clean launch with no Gatekeeper "Apple could not verify" prompt and no manualxattrstep.How it works
After the DMG is built, the workflow signs it with
openssl dgst -sha256 -signusing an RSA-4096 private key supplied via the newTHUKI_INSTALLER_RSA_PRIVATE_KEYActions secret, and uploadsThuki.dmg.sigalongsideThuki.dmg. The private key is written to a temp file and removed on step exit; it never lands on the release.The installer verifies that signature with stock macOS
opensslagainst a public key pinned in the install script. RSA is used (rather than the existing ed25519 updater key) specifically because stock LibreSSL on macOS cannot verify ed25519/minisign signatures, so this path needs no extra tooling on the user's machine. Because the key lives only in CI, a DMG swapped onto a compromised release fails verification and is never installed.Thuki.dmgkeeps its stablereleases/latest/download/URL, so the installer tracks new versions with no per-release changes.Testing
Thuki.dmgwith the private key and verified it with the public key using stock LibreSSL 3.3.6:Verified OK.Verification Failure).Note
The signature only appears starting with the next release that runs this workflow; the matching public key and
install.share managed in the landing-page repo.