Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 43 additions & 29 deletions quickwit/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion quickwit/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ numfmt = "1.2"
oneshot = { version = "0.2", features = ["async", "std"] }
openssl = { version = "0.10", default-features = false }
openssl-probe = "0.2"
opentelemetry = "0.32"
opentelemetry = "0.33"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Upgrade the entire OpenTelemetry dependency family together

When quickwit-common or quickwit-telemetry-exporters is compiled, this direct dependency resolves to opentelemetry 0.33.1 while opentelemetry_sdk, opentelemetry-otlp, opentelemetry-appender-tracing, metrics-opentelemetry, and tracing-opentelemetry remain tied to opentelemetry 0.32.0, as shown by the two core versions in Cargo.lock. The crates pass OpenTelemetry types across those dependency boundaries—for example, quickwit-common::tracing_utils passes the direct crate's Context to OpenTelemetrySpanExt, and telemetry initialization supplies the 0.32 SDK propagator to the direct crate's 0.33 global API—so the nominally distinct types/traits cause compilation failures. Keep the core dependency at 0.32 or upgrade the whole compatible OpenTelemetry family together.

AGENTS.md reference: AGENTS.md:L104-L121

Useful? React with 👍 / 👎.

opentelemetry-appender-tracing = "0.32"
opentelemetry_sdk = { version = "0.32", features = ["rt-tokio"] }
# `default-features = false` drops the default `reqwest-blocking-client`:
Expand Down
Loading