Repository navigation
Return num bytes on truncation - #80
Open
nadav-govari wants to merge 3 commits into
Open
nadav-govari wants to merge 3 commits into
nadav-govari wants to merge 3 commits into
Conversation
guilload
approved these changes
Sep 30, 2026
| self.start_position = truncate_up_to_pos + 1; | ||
| let num_bytes = self.concatenated_records.len(); | ||
| self.concatenated_records.clear(); | ||
| let record_count = self.record_metas.len(); |
Member
There was a problem hiding this comment.
Suggested change
| let record_count = self.record_metas.len(); | |
| let num_records = self.record_metas.len(); |
guilload
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the number of bytes truncated for upcoming Quickwit work. Doing it here is O(1) whereas other approaches are O(N) as they have to walk the queue. We're already walking it here, so it's a natural place to put it.
Also adds queue size to truncate and append outcomes, and puts it on the queue summary. Adds tests.
I went struct instead of tuple because personally I find tuples of the same type confusing (it's easy to mix up which one is first and which is second).