ci: clean up stale .ghaignore entries + re-enable 3 working anchor examples#48
Merged
Merged
Conversation
All 14 steel project paths referenced directories that no longer exist (the steel framework was removed; there is no steel workflow). Removing the dead ignore entries. https://claude.ai/code/session_013dpnF6uSGWXjkJJZseqzcP
These three Anchor examples were already migrated to Anchor 1.0.0 with complete Rust (litesvm/solana-kite) test suites, but were still listed in .ghaignore for reasons that no longer apply: - finance/escrow/anchor: old reason was a JS helpers bug (#40); the test is now pure Rust, so that bug is irrelevant. Verified: anchor test green (4/4 + lib test). - finance/token-swap/anchor: verified anchor build + 18/18 tests pass. - tokens/external-delegate-token-master/anchor: verified 3/3 tests pass. All three verified locally with Anchor 1.0.0, Solana CLI, and surfpool, matching the CI flow (anchor keys sync -> anchor build -> anchor test). Also clarifies basics/pyth/anchor's ignore reason: it fails because pyth-solana-receiver-sdk 1.1.0 pulls a borsh version incompatible with Anchor 1.0 / Solana 3.x (PriceUpdateV2 fails BorshDeserialize). Left ignored pending a compatible upstream SDK. https://claude.ai/code/session_013dpnF6uSGWXjkJJZseqzcP
mikemaccana
force-pushed
the
claude/wonderful-einstein-HmaHM
branch
from
36b09fd to
fdeaccc
Compare
mikemaccana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scoped-down audit of
.github/.ghaignore. Removes entries whose exclusion reasons are stale, and re-enables three Anchor examples verified to pass locally.Changes
1. Remove 14 stale
steelentries — everysteeldirectory was already deleted from the repo; the ignore entries were dead.2. Re-enable 3 Anchor examples (verified locally with Anchor 1.0.0 + Solana CLI + surfpool, full
anchor build+anchor test):finance/escrow/anchor— old reason was a JS-helpers bug (feat(tokens/hackathon): Squads-multisig hackathon prize program #40); the test is pure Rust now. 4/4 pass.finance/token-swap/anchor— 18/18 pass.tokens/external-delegate-token-master/anchor— 3/3 pass.Also documented the real reason
basics/pyth/anchorstays ignored (pyth-solana-receiver-sdk1.1.0 pulls aborshincompatible with Anchor 1.0 / Solana 3.x).Follow-up (split out of this PR): native bankrun tests are broken repo-wide
While verifying a test-harness fix, I found that the native
node:testfiles were being run throughts-mocha, which sees zero mocha tests, prints "0 passing", and exits 0 — sopnpm test(and the Native workflow) reported success even when the in-processnode:testbankrun tests failed. Every native bankrun suite has effectively been unverified (false-green).Switching the runner to
node --import tsx --test(so failures actually propagate) reveals the real problem:solana-bankruncannot execute programs built by the repo's pinned Solana 3.1.14 toolchain. Every native bankrun example fails identically with:Confirmed it is not caused by my changes and not trivially fixable:
solana-bankrun0.3.1 → 0.4.0 (latest).--arch v0/v1/v2/v3.cargo test(litesvm 0.11.0) path passes for the same programs — so the programs are fine; only the JS bankrun runtime is incompatible.This needs a dedicated effort (likely migrating native tests onto the working Rust/litesvm path, or finding a compatible SVM/toolchain) and will land separately.
Still excluded (other follow-ups)
compression/{cutils,cnft-vault,cnft-burn}/anchor— migrated but have no tests.basics/pyth/anchor— upstream SDK/borsh incompatibility.tokens/token-extensions/{metadata,nft-meta-data-pointer}/anchor,tools/shank-and-solita/native— dep bumps.https://claude.ai/code/session_013dpnF6uSGWXjkJJZseqzcP