Typst: resolve CSS generic font families to an installed font - #14986
Open
gordonwoodhull wants to merge 1 commit into
Open
gordonwoodhull wants to merge 1 commit into
gordonwoodhull wants to merge 1 commit into
Conversation
Typst has no generic font families, but typst_css.lua passed `serif`, `sans-serif`, `monospace` and friends straight through, so every compile warned `unknown font family`. `system-ui` and the `ui-*` keywords were not recognized at all. Replace each generic keyword, at its position in the list, with the first available font from an ordered candidate list built from Chromium's per-OS defaults, fontconfig's 60-latin.conf, Modern Font Stacks and Bootstrap's stacks, ending in Typst's bundled fonts so serif, monospace and math always resolve. The keyword is never emitted. If nothing resolves, the keyword is dropped, and an otherwise empty list falls back to Typst's default text font, since Typst rejects an empty font list. No fonts are bundled. Fixes #11683. Replaces #11918 and #14592.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typst has no generic font families, but
typst_css.luapassedserif,sans-serif,monospaceand the rest straight through. Anyfont-familylist or brand typography that used one made Typst warnunknown font family: sans-serifon every compile, and Typst then fell back to whatever it liked.system-uiand theui-*keywords weren't recognized at all, so they were treated as font names. This is thesystem-uistack thatgttables emit (#11683).Each generic keyword is now replaced, at its position in the list, by the first installed font from an ordered candidate list. The lists are built from Chromium's per-OS defaults, fontconfig's
60-latin.conf, Modern Font Stacks and Bootstrap's stacks, with Typst's bundled fonts last soserif,monospaceandmathalways resolve. The keyword itself is never emitted:font-family: Roboto, sans-serifbecomesRobotoif it's installed, and otherwise the first installed sans-serif candidate. The candidate lists live intypst_css.lua, with their sources cited. No fonts are bundled.When nothing in a generic's list is installed (realistically
sans-serifon a bare Linux box), the keyword is dropped. If that leaves the list empty, we use Typst's default text font, because Typst rejects an emptyfont: ().generic(...)is dropped, since Typst has no equivalent.The winning font differs per machine, so the smoke-all fixtures assert only that a concrete family is emitted and that no generic keyword reaches the
.typ.font-filtering-genericspreviously asserted that the keyword was preserved, which is the behavior this changes.This is a backport of quarto-dev/q2#788.
This replaces #11918, which mapped each generic to one fixed font and bundled Noto Sans, and #14592, which dropped generics from the list but still warned when a list contained only generics.
Fixes #11683.